Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isolate_from_data and train_from_data, with refactor entrypoint (tekton prerequisite) #195

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

sunya-ch
Copy link
Contributor

@sunya-ch sunya-ch commented Nov 28, 2023

This PR is a prerequisite for leveraging Tekton pipeline (#194) including:

significant changes:

  • refactor cmd (entrypoint) code by separating cmd_plot.py and cmd_util.py for sub functions
  • add data-path, abs-pipeline-name parameters to specify any data path by argument and to separate pipeline for isolation and output pipeline, respectively
  • add isolate_from_data and train_from_data command to separate run isolator and trainer process out of the pipeline based on preprocessed dataframe. train_from_data introduces a new parameter trainers.
  • allow to create a new data folder if not exist for query command
  • add missing update_thirdparty_metrics call in train command
  • auto fill default_trainers if abs_trainers/dyn_trainers is "default"

minor changes:

  • round MAE, MAPE to 2 digits
  • return -1 if cannot compute MAPE value

documentation changes:

  • remove outdated command in cmd/README.md
  • add description to each command function

Signed-off-by: Sunyanan Choochotkaew [email protected]

Copy link
Contributor

@rootfs rootfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a quite significant change, would appreciate if the doc can be added later.

@rootfs rootfs merged commit e2a3b1b into sustainable-computing-io:main Nov 29, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants