moving to maintained action and splitting up linux github actions yml and #131
Conversation
|
Is the combination of Ubuntu 21.04 and Cubit 2021.4 known to fail before now? |
| uses: svenstaro/upload-release-action@v2 | ||
| - name: Upload binaries into the release | ||
| uses: softprops/action-gh-release@v1 | ||
| if: startsWith(github.ref, 'refs/tags/') |
There was a problem hiding this comment.
Is there a substantive reason to change the condition? Why not put the conditional first?
There was a problem hiding this comment.
That is just how the example suggested to do it. I think that the action handles the condition instead of the yml
https://github.com/softprops/action-gh-release
| - os: debian | ||
| os_version: '10.10' # using a 'string' here as the 0 gets rounded away otherwise | ||
| cubit: 2021.11 | ||
| - os: ubuntu |
There was a problem hiding this comment.
this has now excluded the U21.04 + C2021.4 combination - was that failing before?
There was a problem hiding this comment.
I think it was not failing before. I can't quite figure out why it is failing now.
Thanks for the work here @shimwell - I wonder how to deal with third party actions becoming unsupported in the long term?
I think the newer replacements are usually easier to use which I guess is part of the reason they become the preferred option. They also tend to offer the same or better functionality. So perhaps upgrading actions won't be much trouble. This action repo was kind enough to recommend a replacement one.
There was a problem hiding this comment.
this has now excluded the U21.04 + C2021.4 combination - was that failing before?
I don't quite understand why it no longer works but it seems that U21.04 + C2021.4 was working previously. I can manually upload it to the release of that helps
The existing Github Actions scripts make use of upload-release-asset which is now no longer maintained and suggests using action-gh-release instead.
So I think it might be time to change the GitHub Action used to upload the compressed files to the release.
Additionally as mentioned in the call today the combined action for Ubuntu and Debian upload was getting a bit large so I've split those two into separate yml files which.
The github actions triggered by a test release on my fork all worked as the failing option Ubuntu 21.04 and Cubit 2021.4 has been removed from the matrix.
https://github.com/shimwell/Cubit-plugin/actions