Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MACRO that checks for MOAB error #89

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix MACRO that checks for MOAB error #89

wants to merge 1 commit into from

Conversation

gonuke
Copy link
Member

@gonuke gonuke commented Mar 23, 2021

Fixes #88

This never caused an error in practice, but was incorrect.

@bam241
Copy link
Member

bam241 commented Mar 23, 2021

this looks good to me, we should not worry about the GitHub action failing.
this is coming form elsewhere.

bam241
bam241 previously approved these changes Mar 23, 2021
View reviewed changes
@pshriwise
Copy link
Member

Pretty simple change here. Hopefully it just needs to be rebased to get tests passing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bam241 bam241 bam241 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: macro function in DAGMCExportCommand.cpp
3 participants
@gonuke @bam241 @pshriwise