Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ContextProvider #197

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

abdel-17
Copy link
Collaborator

@abdel-17 abdel-17 commented Dec 30, 2024

TODO: add docs

Copy link

changeset-bot bot commented Dec 30, 2024

⚠️ No Changeset found

Latest commit: e7c4fc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 30, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
runed ✅ Ready (View Log) Visit Preview e7c4fc3

@huntabyte
Copy link
Member

huntabyte commented Dec 31, 2024

I imagine we want to make this an entirely separate thing from Context for code-splitting/reducing unnecessary things on the instance?

Feels like this would be a pretty tight touch:

import { Context } from "runed";

export const MenuContext = new Context<{ open: boolean }>('Menu')
<script lang="ts">
	import { MenuContext } from "./context.js"
</script>

<!-- value is typed -->
<MenuContext.Provider value={{ open: true }}>
	<!-- things... -->
</MenuContext.Provider>

Edit now that I am thinking about it more:
We'd need a way to pass the context somehow into that component on the user's behalf to make this even worth anything 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants