exclude windows from running concurrently

sveltejs · Nov 13, 2024 · 489c692 · 489c692
1 parent 804caa2
commit 489c692
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 16 deletions.
diff --git a/packages/adders/_tests/all-addons/test.ts b/packages/adders/_tests/all-addons/test.ts
@@ -1,12 +1,12 @@
-// import process from 'node:process';
+import process from 'node:process';
 import { expect } from '@playwright/test';
 import { setupTest } from '../_setup/suite.ts';
 import { officialAdders } from '../../index.ts';
 import type { AddonMap, OptionMap } from 'sv';
 
-// const windowsCI = process.env.CI && process.platform === 'win32';
+const windowsCI = process.env.CI && process.platform === 'win32';
 const addons = officialAdders.reduce<AddonMap>((addonMap, addon) => {
-	// if (addon.id === 'storybook' && windowsCI) return addonMap;
+	if (addon.id === 'storybook' && windowsCI) return addonMap;
 	addonMap[addon.id] = addon;
 	return addonMap;
 }, {});

diff --git a/packages/adders/_tests/storybook/test.ts b/packages/adders/_tests/storybook/test.ts
@@ -1,3 +1,4 @@
+import process from 'node:process';
 import { expect } from '@playwright/test';
 import { setupTest } from '../_setup/suite.ts';
 import storybook from '../../storybook/index.ts';
@@ -6,18 +7,23 @@ const { test, variants, prepareServer } = setupTest({ storybook });
 
 let port = 6006;
 
-test.for(variants)('storybook loaded - %s', async (variant, { page, ...ctx }) => {
-	const cwd = await ctx.run(variant, { storybook: {} });
+const windowsCI = process.env.CI && process.platform === 'win32';
+test.for(variants)(
+	'storybook loaded - %s',
+	{ concurrent: !windowsCI },
+	async (variant, { page, ...ctx }) => {
+		const cwd = await ctx.run(variant, { storybook: {} });
 
-	const { close } = await prepareServer({
-		cwd,
-		page,
-		previewCommand: `pnpm storybook -p ${++port} --ci`,
-		buildCommand: ''
-	});
-	// kill server process when we're done
-	ctx.onTestFinished(async () => await close());
+		const { close } = await prepareServer({
+			cwd,
+			page,
+			previewCommand: `pnpm storybook -p ${++port} --ci`,
+			buildCommand: ''
+		});
+		// kill server process when we're done
+		ctx.onTestFinished(async () => await close());
 
-	expect(await page.$('main .sb-bar')).toBeTruthy();
-	expect(await page.$('#storybook-preview-wrapper')).toBeTruthy();
-});
+		expect(await page.$('main .sb-bar')).toBeTruthy();
+		expect(await page.$('#storybook-preview-wrapper')).toBeTruthy();
+	}
+);