Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update storybook to v8.4.0 #298

Closed
wants to merge 2 commits into from

Conversation

manuel3108
Copy link
Member

Relates #296

Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 51c65c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Nov 13, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@298
pnpm add https://pkg.pr.new/sveltejs/cli/svelte-migrate@298

commit: 51c65c3

@AdrianGonz97
Copy link
Member

storybook has already been set to @latest as part of #181, so this PR isn't necessary unless we're wanting to pin it to a specific version again

@JReinhold
Copy link

If CI has been working with latest, maybe it was a temporary issue?

@AdrianGonz97
Copy link
Member

AdrianGonz97 commented Nov 14, 2024

#296 was strictly a local issue and was unrelated to CI. In fact, I don't think we ever saw a CI failure as a result of using @latest.

However, #293 is a CI related issue with storybook where we noticed that we can't run our storybook tests concurrently on windows (see #293 (comment)) in CI (though, it works fine locally).

@manuel3108
Copy link
Member Author

storybook has already been set to @latest as part of #181, so this PR isn't necessary unless we're wanting to pin it to a specific version again

Uhh, somehow didn't notice that!

@manuel3108 manuel3108 closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants