-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade package-manager-detector to add Deno support #313
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 8183d57 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the execute-local
command for Deno (which maps to deno run {0}
) isn't a valid way to execute local binaries, so it breaks during formatting (and will also break for sv check
as we also depend on it there)
I filed a feature request denoland/deno#26918 after discussing it in https://github.com/antfu-collective/package-manager-detector/pull/25/files#r1847062219 |
@AdrianGonz97 I've updated this with a new version that should hopefully work. Can you test again? |
Thanks! The previous issue is now resolved, but now we have another one that could be worked around. Running the storybook add-on is failing as it's attempting to execute it with:
which isn't correct when trying to execute remote scripts. It should instead have the
This could be fixed this on our end, but it doesn't seem to be the intended purpose of the This also raises the question of how should we deal with deno's security features? Should we just add a |
No description provided.