Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependencies script #314

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Conversation

manuel3108
Copy link
Member

@manuel3108 manuel3108 commented Nov 16, 2024

Adds a script pnpm update-dependencies to automatically update the dependencies. This script focuses on

  • updating package.json dependencies (using pnpm update --recursive)
  • updating dependencies that are used while scaffolding addons (using regex and fetch to npm)

As discussed, updating the actual dependencies (packages and addons) should happen separately, since both also require code changes, although minimal.

Copy link

changeset-bot bot commented Nov 16, 2024

⚠️ No Changeset found

Latest commit: 7d366e3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Nov 16, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@314
pnpm add https://pkg.pr.new/sveltejs/cli/svelte-migrate@314

commit: e032ff7

@manuel3108 manuel3108 force-pushed the chore/update-dependencies branch from e032ff7 to 64009d6 Compare November 17, 2024 07:37
@manuel3108 manuel3108 changed the title chore: update dependencies chore: update dependencies script Nov 17, 2024
@manuel3108 manuel3108 marked this pull request as ready for review November 17, 2024 07:38
Copy link
Member

@AdrianGonz97 AdrianGonz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Ended up making a few tweaks, but this should be ready to go:

  • Removed the script that updated the repo's deps since that's something that shouldn't necessarily be tied to updating add-on deps
  • renamed the script and file
  • added a bit more info to the output and some color so it's easier to visually parse
  • added a regex for packages that are defined in object literals (take our tailwind add-on as an example)

@manuel3108
Copy link
Member Author

  • Removed the script that updated the repo's deps since that's something that shouldn't necessarily be tied to updating add-on deps

Sounds logical, this was setup before i figured out that pnpm update -r exists and i was always trying to remember an external tool name.

  • added a regex for packages that are defined in object literals (take our tailwind add-on as an example)

Great point!

@manuel3108 manuel3108 merged commit 651c008 into main Dec 11, 2024
7 checks passed
@manuel3108 manuel3108 deleted the chore/update-dependencies branch December 11, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update dependencies installed by adders to latest versions
2 participants