Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Svelte 5 RC to peerDeps #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Svelte 5 RC to peerDeps #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
},
"peerDependencies": {
"rollup": ">=2.0.0",
"svelte": ">=3.5.0"
"svelte": ">=3.5.0 || >=5.0.0-next.120"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would imagine we should allow any pre-release version here

Suggested change
"svelte": ">=3.5.0 || >=5.0.0-next.120"
"svelte": ">=3.5.0 || >=5.0.0-next.1"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really have an opinion on it. I chose 120 to just peg it to the release candidate. I'm not sure how many people would be using the pre-release who wouldn't want to update.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to commit this change if you want it.

},
"devDependencies": {
"eslint": "^7.14.0",
Expand Down
Loading