Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update type of $props rune #510

Merged
merged 4 commits into from
Apr 22, 2024
Merged

feat: update type of $props rune #510

merged 4 commits into from
Apr 22, 2024

Conversation

baseballyama
Copy link
Member

Follow this PR: sveltejs/svelte#10694

Copy link

changeset-bot bot commented Apr 21, 2024

🦋 Changeset detected

Latest commit: dac262b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Apr 21, 2024

Pull Request Test Coverage Report for Build 8792229478

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.553%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/converts/element.ts 0 1 0.0%
Totals Coverage Status
Change from base Build 8608449314: 0.0%
Covered Lines: 2793
Relevant Lines: 2975

💛 - Coveralls

Comment on lines +241 to +244
<div
class="eslint-editor-monaco-root eslint-editor-monaco-root--wait"
in:loadingTypewriter
></div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed ESLint error which came from sveltejs/svelte#11114.

@@ -14,7 +14,7 @@
position: relative;
height: calc(100vh - 64px);
}
.main > * {
.main > :global(*) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just I fixed an unused CSS error.

@baseballyama
Copy link
Member Author

A recent update stop type exports, but I think this is unintended change.
I will look into this further.

@baseballyama
Copy link
Member Author

I created a PR for this.
sveltejs/svelte#11283

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit 9dddc36 into main Apr 22, 2024
13 checks passed
@ota-meshi ota-meshi deleted the feat/update-runes branch April 22, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants