[fix] fix 'src' attribute judge logic (#6575) #6580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Could somebody please review this PR? |
Conduitry
reviewed
Aug 20, 2021
| @@ -148,7 +148,7 @@ export function get_root_for_style(node: Node): ShadowRoot | Document { | |||
| if (!node) return document; | |||
|
|
|||
| const root = node.getRootNode ? node.getRootNode() : node.ownerDocument; | |||
| if ((root as ShadowRoot).host) { | |||
| if (root && (root as ShadowRoot).host) { | |||
There was a problem hiding this comment.
What is this change intended to address? This seems unrelated to the src attribute handling mentioned in #6575.
There was a problem hiding this comment.
The return of node.ownerDocument is possibly null.
And in the case of Svelte Native returns null at least in this issue #6575.
Therefore it needs to check nullability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is under confirmation at #6575.
fix #6575
Before submitting the PR, please make sure you do the following
[feat],[fix],[chore], or[docs].Tests
npm testand lint the project withnpm run lint