fix(inspector): disable while combo is held when extra key are pressed or leaving browser #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are pressed or leaving browser
dominikg
commented
Aug 20, 2023
| @@ -145,7 +145,11 @@ | |||
| } | |||
|
|
|||
| function is_combo(event) { | |||
| return toggle_combo?.every((key) => is_key_active(key, event)); | |||
| return is_toggle(event) && toggle_combo?.every((key) => is_key_active(key, event)); | |||
There was a problem hiding this comment.
ctrl-shift-X returns false for is_combo now, previously it would return true
dominikg
commented
Aug 20, 2023
| @@ -167,14 +171,13 @@ | |||
| } | |||
|
|
|||
| function keydown(event) { | |||
| if (event.repeat || event.key == null) { | |||
| if (event.repeat || event.key == null || (!enabled && !is_toggle(event))) { | |||
There was a problem hiding this comment.
return early when disabled and the key isn't a toggle
dominikg
commented
Aug 20, 2023
| @@ -267,7 +274,8 @@ | |||
| } | |||
|
|
|||
| function onLeave() { | |||
| if (hasOpened) { | |||
| // disable if a file has been opened or combo is held | |||
| if (enabled && (has_opened || hold_start_ts)) { | |||
There was a problem hiding this comment.
this helps with shortcuts that unfocus the browser window, eg ctrl-shift-print
bluwy
approved these changes
Aug 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduces occurrences of #557