-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dereferenceUses
plugin
#1279
Open
strarsis
wants to merge
37
commits into
svg:main
Choose a base branch
from
strarsis:dereferenceUses-plugin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+380
−0
Open
Changes from 1 commit
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
782a87b
Add plugin file and tests.
strarsis 8594b3a
Add code to replace the `<symbol>` element with configurable wrapper …
strarsis 3bd002b
Fix test.
strarsis cb915dc
Add to plugins.js.
strarsis 48d7c21
Apply linter fix to dereferenceUses plugin.
strarsis 2de6eaa
Resolve package lock conflict with upstream.
strarsis c4397c7
Add new test for plugin (1279#issuecomment-803706532).
strarsis fa93ae0
Apply styles of <use/> element on top of styles of referenced element.
strarsis 137341e
Fix expected result in test.
strarsis 4d658eb
Merge branch 'master' of https://github.com/svg/svgo into dereference…
strarsis 8fd5222
Apply recommended code style.
strarsis 7d9135a
Improve constant and variable names.
strarsis 0e426f6
Improve comment.
strarsis a37eb7b
Fix attribute override logic.
strarsis 45244fc
Merge branch 'master' into dereferenceUses-plugin
strarsis 60088b0
Simplify plugin test description.
strarsis 8a497ef
Simplify plugin tests descriptions.
strarsis 5dc8c65
Use href attribute names array for finding href attribute.
strarsis 246d861
Remove large, rather redundant plugin test.
strarsis 454e338
Rename options argument/variable to params.
strarsis 96d0f7e
Use destructuring for plugin params.
strarsis 470ab35
Merge branch 'main' into dereferenceUses-plugin
strarsis bb15cbe
Add param typings for dereferenceUses plugin.
strarsis e7226cb
Rewrite dereferenceUses plugin for new `svgo` architecture.
strarsis 8db961d
Improve test comments.
strarsis cd30067
Increase test coverage.
strarsis 92dcf8e
Fix `yarn` lockfile.
strarsis 5712fee
Appy prettier.
strarsis 314dd8e
Add `structuredClone` polyfill for older `node`s.
strarsis 869c113
Add TS definitions for `@ungap/structured-clone`.
strarsis e797bb0
Merge remote-tracking branch 'origin' into dereferenceUses-plugin
strarsis 99a01d4
Update imports and plugin declaration for current `svgo`.
strarsis 886ade6
Add plugin documentation in new `svgo` documentation format.
strarsis bdde2ef
Update test fixture files to new `svgo` conventions.
strarsis bb4adde
Add `dereferenceUses` plugin as built-in `svgo` plugin.
strarsis 58697fd
Remove npm lockfile.
strarsis eed23f1
Fix code lint errors in plugin code.
strarsis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Apply recommended code style.
Use xast. Use const where possible. Use native JS manipulation. Add description to plugin tests.
commit 8fd522250ae15c171c85bd1295aefd4782de4f7f
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor with visitor please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure! I am eager to try it with a plugin.