-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mergeText plugin #1908
add mergeText plugin #1908
Conversation
…o lines when applicable (svg#1873)
There are problems with the commits in my branch. Closing this PR, will reopen with a clean copy. |
Thanks for opening and maintaining the pull request! When you do have it open, I'll review it once SVGO v3.2.0 is released. Meanwhile, it will probably help if you update with a rebase instead of merge next time! Assuming git fetch --all
git rebase upstream/main Then if there are any conflicts, you can resolve them and do: git add .
git rebase --continue This results in a clean commit history, no merges required. 👍🏽 git rebase -i HEAD~N # replace N with the number of commits you want to squash
# an interactive editor appears, replace "pick" in all lines except the first with "s"
# now rebase with upstream as normal
git fetch --all
git rebase upstream/main If you ever have trouble with it again, welcome to ask me to fix it for you, and I'll record how I do it. |
Thing is that usually merges work fine and don't include upstream commits in the change view, but I think somewhere commit history got changed, resulting in discontinuity across past upstream and current upstream. I ran into this when rebasing another PR I made, and fixed it by |
Interesting, I always use rebase, so I haven't run into that issue.
In the past, some maintainers have done force pushes to I'm guessing it's because we use the "Squash and merge" strategy to merge pull requests.
I, personally, like "Squash and merge" and "Rebase and merge". I'd recommend contributors/maintainers to rebase to keep local branches up-to-date instead of merging. Looking online, it seems to come down to preference. One way isn't objectively better. I, personally, prefer rebase since I feel merges clutter the commit history. Though, I may consider what's happening now a point for why rebasing is easier. |
Consolidate adjacent
<text>
elements and<text>
elements with a single<tspan>
child.Resolves #964, resolves #1907