chore!: Update commander to v11 #2004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XhmikosR
force-pushed
the
xmr/update-commander
branch
from
526431a to
384bff3
Compare
XhmikosR
force-pushed
the
xmr/update-commander
branch
from
384bff3 to
db5eb60
Compare
XhmikosR
force-pushed
the
xmr/update-commander
branch
from
79a7e0e to
8b7c9ca
Compare
SethFalco
force-pushed
the
xmr/update-commander
branch
from
8b7c9ca to
7a5e8e3
Compare
SethFalco
force-pushed
the
xmr/update-commander
branch
from
7a5e8e3 to
251c6ab
Compare
|
I've rebased for you, migrated away from the method that was deprecated in commander v8, and tacked on a JS Doc for typings. This looks good to me though, most of the breaking changes between major versions didn't affect us at all from what I can tell. Pretty confident this will be fine after looking through the release notes, testing locally, running tests (which includes our command-line interface), etc. We'll see if anything comes up from users that test the release candidate, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commander v11 requires Node.js 16 so this should probably be merged after #2002 and the other PRs.
Please note that this bumps many major versions. I checked commander's release notes, but this could definitely use some more eyes for any breaking changes that might affect svgo.
Ping me when needed for a rebase.