fix: add alias of removeScriptElement to removeScripts #2033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethFalco
force-pushed
the
fix/remove-script-alias
branch
from
f4817b3 to
d91aea4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an alias to convert
removeScriptElementtoremoveScripts.This makes it, so this is less likely to be a breaking change for downstream projects.
The changes to our default plugins are less of an issue because redundant
overridesdon't throw errors, and most downstream projects disabledremoveTitleandremoveViewBoxalready anyway, so that change isn't going to be breaking for them at all.However, the rename of
removeScriptElementwould produce a fatal crash if an end-user had that in their config for a downstream project. So instead, let's alias it so projects like SVGR, ipx, Docusaurus etc, can upgrade to SVGO v4 without having to increment their major version.