removeAttrs: Added optional value filter

[Herman-Freund]

Example:

Remove all "fill" attributes that the value is "none"

{
  removeAttrs: {
    attrs: '*:fill:none'
  }
}

Remove all "fill" attributes where the value is NOT "none"

{
  removeAttrs: {
    attrs: '*:fill:((?!^none$).)*'
  }
}

Remove all "fill" attributes except when the value is white (white, #fff, rgb(255,255,255), etc.)

attrs: [
  "*:fill:((?!^\\s*white\\s*$|^\\s*#(f{3}|f{4}|f{6}|f{8})\\s*$|^\\s*rgba?\\(\\s*(255|100%)\\s*([,\\s]\\s*\\3\\s*){2}([,\\s]\\s*(1|100%)\\s*)?\\)\\s*$|^\\s*hsla?\\(\\s*[\\w.]+\\s*[,\\s]\\s*\\d{1,3}%\\s*[,\\s]\\s*100%\\s*([/,\\s]\\s*(1|100%)\\s*)?).)*",
  ...
]

[Herman-Freund]

@GreLI How can we move this forward? Will pinging the original creator of this plugin help (@bennyschudel)?

Thanks

[frebro]

This would be a very useful addition to the plugin.

[roblevintennis]

maybe should say "to all element regardless of value" (I just removed the extraneous 'and')

[Herman-Freund]

Maybe but I was trying to emphasize that the plugin will make 2 assumptions if there are no separators, 1) match all elements and 2) match any value.

[roblevintennis]

Maybe:

assume it's an attribute name, and apply the transformations to all elements (regardless of their value)

[Herman-Freund]

Doesn't parentheses imply "lesser importance" (e.g. afterthought)? Which is not exactly the message intended to convey.

Thanks

[roblevintennis]

I suppose you could state something like:

if no element separators (:), apply the pattern match against attribute name, otherwise matching on all elements and values

or

if no element separators (:), match on all elements and values applying the pattern match against attribute name specifically

Both would seem to express the functionality of the regex your join will result in.

[Herman-Freund]

Updated

[roblevintennis]

👍

[roblevintennis]

I too think this would be a nice addition to the plugin...Herman chimed in on my PR #999 which is a parity feature with grunt-svgstore and allows for using the SVG trick to style sprites with one more color by using the currentColor value to inherit font's color. That said, I could alternatively use his changes here to achieve with regex filtering {"attrs":"*:(stroke|fill):((?!^currentColor$).)*"} so that's a definite use case for getting this in.

Here's an article I wrote on CSS tricks which explains the use case aforementioned:
https://css-tricks.com/gotchas-on-getting-svg-into-production/#article-header-id-11

[raduflp]

any plans to merge this PR in the near future?

[MattMakes]

@deepsweet @GreLI Any way to get this moved through?

[Jetski5822]

Any way this can be merged in?

[roblevintennis]

It's hard to not wonder if SVGO is really maintained at this point with no feedback from core folk for nearly 6 months. It's such a good tool I certainly hope that is not the case. @Herman-Freund did you ever hear any feedback outside of this channel on your work? I can't see why we wouldn't want this feature added esp. given the positive comments from various people here.

[Herman-Freund]

@Herman-Freund did you ever hear any feedback outside of this channel on your work?

No 😕

Thanks everyone for the positive feedback!

[Herman-Freund]

@GreLI
Other than #1055, are there any reasons for not merging this?

Thanks

[GreLI]

Merged in d23355e (there was a conflict with test from other PR).

[GreLI]

SVGO v1.2.0 has been just released!