Update redis health check #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to recent changes in the redis library, a PING command is now routed to all main nodes by default, rather than a single random node, and all must succeed. This makes connections particularly fragile if a single node is having transient issues. So, in an effort to maximize uptime, let's require a successful response from only one node.
jaymell
force-pushed
the
redis-health-check
branch
from
f6ed2d1 to
75d1198
Compare
svix-aaron1011
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to recent changes in the redis library, a PING command is now
routed to all main nodes by default, rather than a single random node,
and all must succeed. This makes connections particularly fragile if
a single node is having transient issues. So, in an effort to
maximize uptime, let's require a successful response from only one
node.