Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed code from the old Mongoose back-end and re-organised menu's #1126

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Removed code from the old Mongoose back-end and re-organised menu's #1126

wants to merge 3 commits into from

Conversation

SpookyBoy99
Copy link
Contributor

Closes #1109. The Mongoose data will not deleted from the database with this PR and Mongoose top-ups are still shown in the transaction history and exports.

SilasPeters
SilasPeters reviewed Sep 15, 2024
View reviewed changes
Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine at first glance, but we should carefully test all/most controllers of koala to see if nothing breaks

@SpookyBoy99
Copy link
Contributor Author

This PR makes no changes to the database so if something breaks we can easily revert to an earlier deployment and not data will be lost. I have looked through all the pages that I know of and they seem functional (including the export of transactions)

@TobiasDeBruijn
Copy link
Member

Looks good to me. @SilasPeters are there any blockers left on this PR?

@SilasPeters
Copy link
Member

I am not aware of any blockers. I would say let's review, test and merge! But @stickyPiston probably has a better view on this.

@SpookyBoy99
Copy link
Contributor Author

If @stickyPiston and @TobiasDeBruijn have time for a quick review, I can resolve the merge conflicts and merge this PR. I don't have a lot of time these days so if many more merge conflicts will arise in the mean time I don't think I will have enough time to resolve them in the future.

SilasPeters
SilasPeters requested changes Dec 30, 2024
View reviewed changes
Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick scan. Our time would be better spend to test every endpoint in staging.

app/controllers/admin/logs_controller.rb
@limit = params[:limit] ? params[:limit].to_i : 50

@pagination, @impressions = pagy(Impression.all.order(created_at: :desc),
items: params[:limit] ||= 50)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
items: params[:limit] ||= 50)
items: @limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SilasPeters SilasPeters SilasPeters requested changes

@TobiasDeBruijn TobiasDeBruijn TobiasDeBruijn approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Mongoose checkout code in the backend
3 participants
@SpookyBoy99 @TobiasDeBruijn @SilasPeters