Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added verbose (failure) logging to the seeding process #1127

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

SpookyBoy99
Copy link
Contributor

@SpookyBoy99 SpookyBoy99 commented Sep 14, 2024

This PR also removes the seeding of Mongoose transactions, but those aren't necessary anymore anyway

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good initiative, left a few comments. The log looks so satisfying!

However, the logs also show that many transactions fail, due to a repeating error: Redirect uri Transactie kan niet leeg zijn.

-- Creating member transactions
   [ Ok ] Successful transaction by Raun Bosgoed of 21.42 for [11, 20] using pin
   [ Ok ] In progress transaction by Raun Bosgoed of 71.96 for [31, 7, 32, 23, 12, 39] using pin
   [Fail] Failed transaction by Raun Bosgoed of 40.03 for [20, 36, 11] using ideal
          > Redirect uri Transactie kan niet leeg zijn
   [Fail] Successful transaction by Raun Bosgoed of 29.44 for [32, 6, 13, 7, 23, 24] using ideal
          > Redirect uri Transactie kan niet leeg zijn
   [ Ok ] Failed transaction by Raun Bosgoed of 21.33 for [32, 6, 12] using pin
   [Fail] Successful transaction by Raun Bosgoed of 49.82 for [5, 38, 37, 3, 20] using ideal
          > Redirect uri Transactie kan niet leeg zijn
   [Fail] Failed transaction by Raun Bosgoed of 32.18 for [5, 14, 17] using ideal
          > Redirect uri Transactie kan niet leeg zijn
   [ Ok ] Failed transaction by Raun Bosgoed of 18.36 for [13, 12] using pin
   [ Ok ] Failed transaction by Raun Bosgoed of 3.23 for [20] using pin
   [ Ok ] Failed transaction by Raun Bosgoed of 29.04 for [5, 23] using pin
   [ Ok ] In progress transaction by Raun Bosgoed of 64.86 for [31, 17, 2, 26, 11, 3] using pin
   [Fail] In progress transaction by Raun Bosgoed of 61.57 for [11, 38, 7, 12, 13, 3] using ideal
          > Redirect uri Transactie kan niet leeg zijn
...

db/seeds/payments.rb Show resolved Hide resolved
@SpookyBoy99
Copy link
Contributor Author

The Redirect uri Transactie kan niet leeg zijn error is the reason for implementing these logs as I noticed that during seeding only 'pin' transactions were saved in the database. The issue causing this error has already been found using these logs and fixed in #1128.

@SilasPeters
Copy link
Member

SilasPeters commented Sep 15, 2024

Then once you merge master again into this I will approve!

Edit: or is it perhaps possible to let the failures show up in red?

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whilst the seeding still shows failures, that means this PR did it's job. Ready to merge!

@SpookyBoy99 SpookyBoy99 merged commit c995266 into master Sep 15, 2024
1 check passed
@SpookyBoy99 SpookyBoy99 deleted the debt/seed-logging branch September 15, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants