-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added verbose (failure) logging to the seeding process #1127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good initiative, left a few comments. The log looks so satisfying!
However, the logs also show that many transactions fail, due to a repeating error: Redirect uri Transactie kan niet leeg zijn
.
-- Creating member transactions
[ Ok ] Successful transaction by Raun Bosgoed of 21.42 for [11, 20] using pin
[ Ok ] In progress transaction by Raun Bosgoed of 71.96 for [31, 7, 32, 23, 12, 39] using pin
[Fail] Failed transaction by Raun Bosgoed of 40.03 for [20, 36, 11] using ideal
> Redirect uri Transactie kan niet leeg zijn
[Fail] Successful transaction by Raun Bosgoed of 29.44 for [32, 6, 13, 7, 23, 24] using ideal
> Redirect uri Transactie kan niet leeg zijn
[ Ok ] Failed transaction by Raun Bosgoed of 21.33 for [32, 6, 12] using pin
[Fail] Successful transaction by Raun Bosgoed of 49.82 for [5, 38, 37, 3, 20] using ideal
> Redirect uri Transactie kan niet leeg zijn
[Fail] Failed transaction by Raun Bosgoed of 32.18 for [5, 14, 17] using ideal
> Redirect uri Transactie kan niet leeg zijn
[ Ok ] Failed transaction by Raun Bosgoed of 18.36 for [13, 12] using pin
[ Ok ] Failed transaction by Raun Bosgoed of 3.23 for [20] using pin
[ Ok ] Failed transaction by Raun Bosgoed of 29.04 for [5, 23] using pin
[ Ok ] In progress transaction by Raun Bosgoed of 64.86 for [31, 17, 2, 26, 11, 3] using pin
[Fail] In progress transaction by Raun Bosgoed of 61.57 for [11, 38, 7, 12, 13, 3] using ideal
> Redirect uri Transactie kan niet leeg zijn
...
The |
Then once you merge master again into this I will approve! Edit: or is it perhaps possible to let the failures show up in red? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst the seeding still shows failures, that means this PR did it's job. Ready to merge!
This PR also removes the seeding of Mongoose transactions, but those aren't necessary anymore anyway