Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Mollie v2 API: Part 2 electric boogaloo #1147

Merged
merged 15 commits into from
Dec 28, 2024
Merged

Conversation

leuke-naam
Copy link
Contributor

Fixes issues with #1133

@leuke-naam leuke-naam enabled auto-merge (squash) December 26, 2024 13:33
TobiasDeBruijn
TobiasDeBruijn previously approved these changes Dec 26, 2024
Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@SilasPeters
Copy link
Member

@leuke-naam and @TobiasDeBruijn I pulled a big brain and tested this branch on staging without merging, by simply checking out this branch and restarting koala 🧠 . Everything seems to work! Two things though:

  1. If the payment is left as 'open', the user is not notified, but I believe @leuke-naam showed me once that a blue banner displaying 'your payment is being processed' should pop up. If that's true, that did not work.
  2. The payments are in test mode, but I assume this is toggled off when a different MOLLIE_TOKEN is used in .env in production.

@leuke-naam
Copy link
Contributor Author

@leuke-naam and @TobiasDeBruijn I pulled a big brain and tested this branch on staging without merging, by simply checking out this branch and restarting koala 🧠 . Everything seems to work! Two things though:

  1. If the payment is left as 'open', the user is not notified, but I believe @leuke-naam showed me once that a blue banner displaying 'your payment is being processed' should pop up. If that's true, that did not work.
  2. The payments are in test mode, but I assume this is toggled off when a different MOLLIE_TOKEN is used in .env in production.
  1. Payment status open is not applicable for iDeal payments, if in the future we were to accept more payment types we could handle this status
  2. Correct

@SilasPeters
Copy link
Member

Then everything works! Somehow GitHub complains some requirements for merging are not met, so I will admin abuse

@SilasPeters SilasPeters merged commit 0d85b36 into master Dec 28, 2024
1 check passed
@SilasPeters SilasPeters deleted the feat/mollie-v3 branch December 28, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants