add from until options to deploy.py #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansible/deploy.py
Outdated
| help="Determine from which playbook to start the deploy from", | ||
| ) | ||
| @click.option( | ||
| "--until", "until_playbook", help="Determine until which playbook to run the deploy" |
There was a problem hiding this comment.
there is only one playbook but multiple roles. The text should be until which role (same for the --from option)
| roles = roles[: roles.index(until_playbook) + 1] | ||
| from_until = True | ||
|
|
||
| final_roles = ",".join(roles) |
There was a problem hiding this comment.
Could you inline this variable? It is only used once at line 121
HugoPeters1024
approved these changes
Oct 10, 2023
ansible/deploy.py
Outdated
| @@ -50,6 +65,8 @@ def deploy( | |||
| env["ANSIBLE_STDOUT_CALLBACK"] = "yaml" | |||
| env["ANSIBLE_VAULT_IDENTITY"] = host | |||
| env["ANSIBLE_SSH_PIPELINING"] = "true" | |||
| env["ANSIBLE_ROLES_PATH"] = "roles/" | |||
There was a problem hiding this comment.
This actually breaks when not using WSL. Could you either remove these changes or somehow make a resilient check to only execute this statements when running inside of WSL?
|
Fixing and merging this PR because we want to have these changes for upcoming tasks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #402