Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds roles to deploy notifications and seperate discord notifications #471

Closed
wants to merge 0 commits into from

Conversation

SilasPeters
Copy link
Member

@SilasPeters SilasPeters commented Sep 28, 2024

This PR aims to clarify what is being deployed, and decrease the noise given by the deploy notifications. This is made possible by:

  • Adding the roles to the deploy start notification
  • Utilizing a new discord hook for both staging and production: the deployments hook. For both staging and production, there will be the production/staging channel (current), and (production|staging)-deployments (new). People can mute what they want. This PR supports differentiating the two hooks.

The bitwarden secret containing the discord webhook has been updated to reflect both production and staging webhooks.

To satisfy the linter, I renamed the fallacious-rooster role to rooster.

Once merged, I will create two new channels and update the webhooks to point to the new deployments channels.

@SilasPeters SilasPeters added the enhancement Proposes (changes to) a feature label Sep 28, 2024
@SilasPeters SilasPeters self-assigned this Sep 28, 2024
@SilasPeters SilasPeters marked this pull request as ready for review September 28, 2024 22:33
TobiasDeBruijn
TobiasDeBruijn previously approved these changes Sep 30, 2024
@SilasPeters SilasPeters dismissed TobiasDeBruijn’s stale review September 30, 2024 19:32

The merge-base changed after approval.

@SilasPeters SilasPeters deleted the chore/refined-noise branch September 30, 2024 19:34
@SilasPeters
Copy link
Member Author

Did a small whoopsie with interactive rebase, but the changes have been applied to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Proposes (changes to) a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants