Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove nix, introduce venv #63

Closed
wants to merge 5 commits into from

Conversation

stickyPiston
Copy link
Member

closes #61

@SamStaijen
Copy link

wouldn't the amazing world of docker remove version management for the end-user?

@stickyPiston
Copy link
Member Author

Yes, it would, but I'd rather have that in a separate PR. After all, this repository doesn't have a dev container setup yet, which could automate that for the developer.

Copy link
Member

@SilasPeters SilasPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are using pyenv, you could add a .python-version file containing 3.9. Then with just pyenv sync one can enable and install the right version. Also, then the version can be abstracted from the readme.

Using venv is a good choice, but perhaps pyenv-virtualenv might be an interesting wrapper. Then you don't need to think about using venv from within the right python version.

In general, so I read, virtualenv has more features than venv.

Frankly, I'm only familiar with pyenv, but I believe that we can simplify some of the steps a user has to take.

@stickyPiston
Copy link
Member Author

Using venv is a good choice, but perhaps pyenv-virtualenv might be an interesting wrapper. Then you don't need to think about using venv from within the right python version.

One thing to note, though, is that pyenv does not support windows officially, so we can't only rely on pyenv.

If you are using pyenv, you could add a .python-version file containing 3.9. Then with just pyenv sync one can enable and install the right version. Also, then the version can be abstracted from the readme.

A .python-version file does sound like a good addition.

In general, so I read, virtualenv has more features than venv.

From what I can see from virtualenv's website the extra features are not really relevant for us. But we can mention virtualenv in the readme as an alternative for venv if we want that.

@SilasPeters
Copy link
Member

If there is no Windows support, duck windows then we should just keep this solution. I would like to see the .pytnon-versio file though

@SilasPeters
Copy link
Member

If there is no Windows support, duck windows then we should just keep this solution. I would like to see the .pytnon-versio file though

With the readme suggesting pyenv sync to install on Linux

@SilasPeters
Copy link
Member

Have not tested it though

@SilasPeters SilasPeters deleted the refactor/remove-nix-introduce-venv branch December 18, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove nix in favour of venv
3 participants