-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove nix, introduce venv #63
Conversation
wouldn't the amazing world of docker remove version management for the end-user? |
Yes, it would, but I'd rather have that in a separate PR. After all, this repository doesn't have a dev container setup yet, which could automate that for the developer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are using pyenv, you could add a .python-version
file containing 3.9
. Then with just pyenv sync
one can enable and install the right version. Also, then the version can be abstracted from the readme.
Using venv is a good choice, but perhaps pyenv-virtualenv might be an interesting wrapper. Then you don't need to think about using venv from within the right python version.
In general, so I read, virtualenv has more features than venv.
Frankly, I'm only familiar with pyenv, but I believe that we can simplify some of the steps a user has to take.
One thing to note, though, is that pyenv does not support windows officially, so we can't only rely on pyenv.
A
From what I can see from virtualenv's website the extra features are not really relevant for us. But we can mention virtualenv in the readme as an alternative for venv if we want that. |
If there is no Windows support, |
With the readme suggesting |
Have not tested it though |
closes #61