Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ideal topups #65

Merged
merged 19 commits into from
Jan 2, 2025
Merged

feat: ideal topups #65

merged 19 commits into from
Jan 2, 2025

Conversation

stickyPiston
Copy link
Member

closes #60

@stickyPiston stickyPiston linked an issue Dec 16, 2024 that may be closed by this pull request
@TobiasDeBruijn
Copy link
Member

Important note: We used to have one Mollie API key, we now have multiple:

  • Koala
  • Pretix
  • Mongoose
    I think this will have to be changed in SadServer, but Mongoose should use the Mongoose balance in Mollie, and use the appropriate API key for it (from Mollie)

@stickyPiston
Copy link
Member Author

What do you mean with mongoose balance in "but Mongoose should use the Mongoose balance in Mollie" exactly?

@TobiasDeBruijn
Copy link
Member

So within our Mollie account we used to have just one 'Balance', which is a thing our users pay into. So if you pay your Koala activities, the money goes into that balance. Mollie then pays us that balance weekly (or whatever we configure).

This poses a problem for us treasurers. Every monday we need to split out this balance into it's separate components, currently only Pretix and Koala. However, recently I introduced two new balances: Pretix and Mongoose. This way, I get three seperate pay-outs every week, one for each product. This means I don't have to split it out manually anymore.

For mongoose (or Pretix), the only thing that changes is the Mollie API key used.

@stickyPiston
Copy link
Member Author

Ahhh alright, the mollie api client only receives the api key that is configured in the .env file and does nothing with balances and whatnot, so i reckon that should be fine.

admin_board_view/templates/user_home.html Outdated Show resolved Hide resolved
admin_board_view/views.py Outdated Show resolved Hide resolved
@TobiasDeBruijn
Copy link
Member

Ahhh alright, the mollie api client only receives the api key that is configured in the .env file and does nothing with balances and whatnot, so i reckon that should be fine.

Yep that is fine! It's something to consider when deploying, though. The secrets probably still need to be created

@stickyPiston stickyPiston merged commit 31b321c into master Jan 2, 2025
@stickyPiston stickyPiston deleted the feat/ideal-topups branch January 2, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iDeal support
2 participants