Require boards to have an end date (#3752)

* Added a clean function to prevent broad with no start or stop date being created. * Removed bogus test on line 255 which created a NoneType board. --------- Co-authored-by: Lisanne Weidmann <[email protected]>
svthalia · Jul 10, 2024 · d9b6f55 · d9b6f55
1 parent 9f366ea
commit d9b6f55
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 3 deletions.
diff --git a/website/activemembers/models.py b/website/activemembers/models.py
@@ -215,6 +215,23 @@ def save(self, **kwargs):
         self.active = True
         super().save(**kwargs)
 
+    def clean(self):
+        if self.since is None:
+            raise ValidationError(
+                {
+                    "since": _("Please insert a starting year for the new board."),
+                }
+            )
+
+        if self.until is None:
+            raise ValidationError(
+                {
+                    "until": _(
+                        "Please insert the year until when the board is active."
+                    ),
+                }
+            )
+
     def get_absolute_url(self):
         return reverse(
             "activemembers:board", args=[str(self.since.year), str(self.until.year)]

diff --git a/website/activemembers/tests.py b/website/activemembers/tests.py
@@ -287,8 +287,5 @@ def test_create_unique_period2(self):
         b.since = b.since.replace(year=1991, month=9, day=2)
         b.full_clean()
 
-        b.until = None
-        b.full_clean()
-
     def test_get_absolute_url(self):
         self.testboard.get_absolute_url()