WIP Svub specific events with payloads #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
svub
commented
Oct 11, 2024
svub
commented
- added custom events for each type of function and callback -- will make front-end much easier + adds semantic events + allows for custom payloads for each event (needed in some parts already, might be more in the future)
- added value:... to contract deployment to allow for gas to be funded to the gateway
- moved checking if the given msg.value is enough to also fund the gateway into a modifier
latest error `ProviderError: Error: Transaction reverted: contract call run out of gas and made the transaction revert` after running `yarn chain` in one terminal tab, and then running `yarn deploy --network localhost` in another terminal tab
attempted improvements
…s package-lock and yarn.lock)
…nunya into svub-specific-events-with-payloads
…using global state for communication; update secret to be of type string in SC; includes hack to convert requestId to bigint; TODO: make dummyContract call ...Callback to test front-end logic
…nunya into svub-specific-events-with-payloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.