fix bug triggering #117, leading to loosing components during "bom map" #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also contains an unrelated change to a TODO comment which was still referencing an old, internal code.siemens.com issue and is now updated to the new Github issue I created today. |
In case of paring errors in the version number, an empty ComparableVersion object was created, leading to an exception in release sorting in map_bom_item_no_cache(). This was caught by the caller map_bom_to_releases(), but lead to this component being missing completely from the output BOM. This fixes the obvious part of #117. However, I still think that the catch-all exception handling in map_bom_to_releases() should be re-considered.
The was a reference to our old, internal issue tracker, so I migrated this issue to Github #118 and updated the reference.
gernot-h
force-pushed
the
gernot/fix-trigger-of-117
branch
from
f450fd3 to
ad73a3f
Compare
tngraf
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #117, invalid SW360 version numbers (which can't be parsed by ComparableVersion) lead to an exception caught quite late, leading to "bom map" forgetting a component in the output BOM.
This PR makes the exception being caught in time, but in my eyes doesn't completely fix #117 as other exceptions in the long code base of map_bom_* can lead to the same problem, so we should still discuss error handling in #117.