Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework some project and bom methods #35

Merged
merged 5 commits into from
Aug 8, 2023
Merged

Rework some project and bom methods #35

merged 5 commits into from
Aug 8, 2023
+117 −89

Commits on Jul 31, 2023

  1. refactor(project): move generic helpers to base class 

    Move some reusable code from project classes to base class.
    @gernot-h
    gernot-h committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    c79d5e3 View commit details
    Browse the repository at this point in the history

  2. test(bom_downloadsources): fix copy-paste error in class name

    @gernot-h
    gernot-h committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    b7e1568 View commit details
    Browse the repository at this point in the history

  3. test(base): refactor output capture methods 

    They now allow an arbitrary number of arguments, so we also don't neet
the _no_args variant any more.
    @gernot-h
    gernot-h committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    c3171b5 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2023

  1. refactor(bom downloadsources): narrow relpath helper 

    Replace have_relative_source_file_path() helper function by a generic
have_relative_ext_ref_path() which can be re-used for other tasks.

To be sure we do the right thing, also add test cases for absolute and
relative paths.
    @gernot-h
    gernot-h committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    0e453ad View commit details
    Browse the repository at this point in the history

  2. refactor: move ext_ref relpath helper to CycloneDxSupport

    @gernot-h
    gernot-h committed Aug 5, 2023
    Configuration menu
    Copy the full SHA
    2a2c2bf View commit details
    Browse the repository at this point in the history