Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

two fixes for "bom DownloadSources" if no URL is set #48

Merged
merged 2 commits into from
Nov 25, 2023
Merged

two fixes for "bom DownloadSources" if no URL is set #48

merged 2 commits into from
Nov 25, 2023

Conversation

gernot-h
Copy link
Collaborator

@gernot-h gernot-h commented Nov 22, 2023 •
edited
Loading

Fixes #46
Fixes #47

@gernot-h
fix(bom DownloadSources): handle missing URLs in BOMs
8eb748d 
Thanks to @Garbald for the report and the fix!

Fixes #46
@gernot-h
fix(bom Downloadsources): inconsistent data on empty url
9e772ec 
Due to an uninitialized variable, data from one BOM item is stored in
another item if this has no url set.

Thanks to @Garbald for reporting and the fix!

Fixes #47
@gernot-h
Copy link
Collaborator Author

@Garbald, I mostly took over your fixes from #46 and #47.

If you have time, please check if this correctly addresses your issues!

@tngraf tngraf merged commit c4a1e4d into main Nov 25, 2023
@tngraf
Copy link
Collaborator

tngraf commented Nov 25, 2023

Thanks a lot, @Garbald and @gernot-h.

@gernot-h gernot-h deleted the fix-bom-downloadsources branch December 8, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tngraf tngraf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad handling of missing sources. crash in "bom downloadsources"
2 participants
@gernot-h @tngraf