Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): add support for [email protected] #30

Merged
merged 1 commit into from
Nov 9, 2023
Merged

chore(deps): add support for [email protected] #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 2 additions & 11 deletions packages/react-scripts/config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,6 @@ module.exports = function (webpackEnv) {
plugins: path.resolve(paths.appSrc, 'plugins/'),
// This alias allows us to import presets as absolute path
presets: path.resolve(paths.appSrc, 'presets/'),
// This alias doesn't pull any languages into bundles and works as monaco-editor-core was installed
'monaco-editor$': 'monaco-editor/esm/vs/editor/edcore.main.js',
// This alias makes sure we don't pull two different versions of monaco-editor
'monaco-editor': '/node_modules/monaco-editor',
// This alias makes sure we're avoiding a runtime error related to this package
Expand All @@ -373,6 +371,7 @@ module.exports = function (webpackEnv) {
// Make sure your source files are compiled, as they will not be processed in any way.
new ModuleScopePlugin(paths.appSrc, [
paths.appPackageJson,
'/node_modules/monaco-editor',
reactRefreshRuntimeEntry,
reactRefreshWebpackPluginRuntimeEntry,
babelRuntimeEntry,
Expand All @@ -397,15 +396,7 @@ module.exports = function (webpackEnv) {
// Handle node_modules packages that contain sourcemaps
shouldUseSourceMap && {
enforce: 'pre',
exclude: [
/@babel(?:\/|\\{1,2})runtime/,
/vscode-languageclient/,
/vscode-languageserver-protocol/,
/vscode-jsonrpc/,
/autolinker/,
/@jsdevtools\/ono/,
/@stoplight/,
],
exclude: [/autolinker/, /@jsdevtools\/ono/, /@stoplight/],
test: /\.(js|mjs|jsx|ts|tsx|css)$/,
loader: require.resolve('source-map-loader'),
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react-scripts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
"buffer": "^6.0.3",
"react": ">= 16",
"typescript": "^3.2.1 || ^4",
"monaco-editor": ">= 0.34.1",
"monaco-editor": ">= 0.44.0",
"stream-browserify": "^3.0.0",
"stream-http": "^3.2.0",
"url": ">=0.11.2"
Expand Down