Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: Clone submodules via https #4

Merged
merged 1 commit into from
Jul 4, 2019
Merged

Update: Clone submodules via https #4

merged 1 commit into from
Jul 4, 2019

Conversation

ken-ton
Copy link
Contributor

@ken-ton ken-ton commented Jul 4, 2019

Please change the method of cloning submodule to https.

@easonlin404
Copy link
Member

Why use https is better than ssh?

@ken-ton
Copy link
Contributor Author

ken-ton commented Jul 4, 2019 •
edited
Loading

In the case of ssh, key pair authentication is required.
We may not be able to smoothly clone in containers where CI or key pair is not set.

dep ensure -update
--
Solving failure: No versions of github.com/swaggo/files met constraints:
master: unexpected error while defensively updating submodules: Cloning into '/go/pkg/dep/sources/https---github.com-swaggo-files/swagger-ui'...
Host key verification failed.
fatal: Could not read from remote repository.

@easonlin404
Copy link
Member

Thanks for your explanation.

@easonlin404 easonlin404 merged commit 630677c into swaggo:master Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easonlin404 easonlin404 easonlin404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ken-ton @easonlin404