✨ ignore failed images for non-production Netlify deploys #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has hurt us multiple times. Maybe we can move all images to Imgur? |
|
That was suggested in #578 but it seems like that's against their ToS. I know both Github Actions and Netlify support caching so that's the route I was thinking of going |
aslafy-z
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no issue
We use Netlify to preview changes, which are especially useful in design PRs (e.g. #652). Unfortunately, we depend on third parties for images, and you can never trust the network. This PR drops
gulp-download-streamin favor of an async, stream-based image downloader. This allows us finer control of the image download pipeline (so in the future, we can also cache images 🥳), and lets the Netlify build pass in non-production environments even if some images are broken