Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a table for completed jobs #460

Open
wants to merge 7 commits into
base: development
Choose a base branch
from

Conversation

ConnorChristie
Copy link

@ConnorChristie ConnorChristie commented May 17, 2021

I thought it would be nice to add a table of completed jobs to Swar, here is what it looks like:

(venv) connor@DESKTOP-R94GGFU:/mnt/c/Git/Swar-Chia-Plot-Manager$ python manager.py history
===============================================================================================================================================================
k           start                  end           total_time                  phase_times                   buffer    threads   working_space      temp_dir
===============================================================================================================================================================
32   2021-05-15 06:10:21   2021-05-15 16:00:01   09:49:40     03:15:01 / 01:33:34 / 04:40:39 / 00:20:24   4000 MiB   2         269 GiB         /data/nvme2
32   2021-05-15 16:51:45   2021-05-16 03:41:20   10:49:34     01:59:47 / 01:24:17 / 07:14:09 / 00:11:19   6000 MiB   8         269 GiB         /data/nvme1
32   2021-05-15 16:51:45   2021-05-15 23:59:46   07:08:00     02:04:14 / 01:26:03 / 03:23:35 / 00:14:06   6000 MiB   8         269 GiB         /data/nvme2
32   2021-05-15 16:51:45   2021-05-15 23:56:04   07:04:18     02:03:29 / 01:24:16 / 03:22:56 / 00:13:35   6000 MiB   8         269 GiB         /data/nvme3
32   2021-05-15 17:52:24   2021-05-16 02:10:09   08:17:45     02:39:49 / 01:36:04 / 03:44:11 / 00:17:39   6000 MiB   4         269 GiB         /data/nvme2
32   2021-05-15 17:52:24   2021-05-16 01:57:08   08:04:44     02:38:27 / 01:34:35 / 03:36:56 / 00:14:44   6000 MiB   4         269 GiB         /data/nvme3
32   2021-05-15 18:52:28   2021-05-16 03:45:44   08:53:15     02:57:27 / 01:37:33 / 04:01:40 / 00:16:34   6000 MiB   4         269 GiB         /data/nvme2
32   2021-05-15 18:52:28   2021-05-16 03:24:29   08:32:00     02:48:10 / 01:37:45 / 03:51:22 / 00:14:41   6000 MiB   4         269 GiB         /data/nvme3
32   2021-05-15 19:52:33   2021-05-16 05:07:41   09:15:08     02:59:01 / 01:41:32 / 04:17:59 / 00:16:34   6000 MiB   4         269 GiB         /data/nvme2
32   2021-05-15 19:52:33   2021-05-16 04:51:22   08:58:49     02:57:24 / 01:38:57 / 04:06:12 / 00:16:14   6000 MiB   4         269 GiB         /data/nvme3
32   2021-05-15 20:52:38   2021-05-16 06:24:50   09:32:11     03:07:01 / 01:46:10 / 04:22:07 / 00:16:51   6000 MiB   4         269 GiB         /data/nvme3
32   2021-05-16 06:53:44   2021-05-16 12:54:16   06:00:32     02:08:14 / 01:16:06 / 02:26:34 / 00:09:37   6000 MiB   4         269 GiB         /mnt/md0
32   2021-05-16 07:09:00   2021-05-16 13:11:45   06:02:45     02:09:26 / 01:17:15 / 02:26:33 / 00:09:30   6000 MiB   4         269 GiB         /mnt/md0
32   2021-05-16 07:14:00   2021-05-16 13:19:10   06:05:09     02:11:08 / 01:17:37 / 02:26:52 / 00:09:31   6000 MiB   4         269 GiB         /mnt/md0
32   2021-05-16 07:19:00   2021-05-16 13:26:07   06:07:06     02:11:36 / 01:18:02 / 02:27:57 / 00:09:30   6000 MiB   4         269 GiB         /mnt/md0
32   2021-05-16 09:02:07   2021-05-16 15:18:25   06:16:17     02:18:03 / 01:20:54 / 02:27:39 / 00:09:39   6000 MiB   4         269 GiB         /mnt/md0
32   2021-05-16 09:19:09   2021-05-16 15:33:04   06:13:55     02:15:06 / 01:21:53 / 02:27:42 / 00:09:13   6000 MiB   4         269 GiB         /mnt/md0
32   2021-05-16 09:26:09   2021-05-16 15:39:48   06:13:39     02:14:45 / 01:22:00 / 02:27:38 / 00:09:14   6000 MiB   4         269 GiB         /mnt/md0
32   2021-05-16 17:05:27   2021-05-16 22:58:19   05:52:52     02:05:58 / 01:15:38 / 02:22:10 / 00:09:06   6000 MiB   4         269 GiB         /mnt/md0/temp
32   2021-05-16 17:10:51   2021-05-16 23:06:28   05:55:36     02:07:57 / 01:16:09 / 02:22:13 / 00:09:17   6000 MiB   4         269 GiB         /mnt/md0/temp
32   2021-05-16 17:15:52   2021-05-16 23:15:03   05:59:11     02:09:30 / 01:16:31 / 02:23:39 / 00:09:29   6000 MiB   4         269 GiB         /mnt/md0/temp
32   2021-05-16 17:20:52   2021-05-16 23:17:16   05:56:23     02:07:54 / 01:16:26 / 02:22:51 / 00:09:10   6000 MiB   4         269 GiB         /mnt/md0/temp
===============================================================================================================================================================

@swar
Copy link
Owner

swar commented May 17, 2021

This looks good. I can get behind someone making a suggestion AND doing the work themselves. 😄

@swar swar changed the base branch from main to development May 17, 2021 06:58
@swar
Copy link
Owner

swar commented May 17, 2021

Just a quick request from you @ConnorChristie when you get a chance. I can probably do this myself tomorrow if you cannot. Can you keep the _analyze_log_end_date() method in there. It will remove the overheard of searching for everything when I do not need all that information returned for the view (the regular view).

Additionally, can you merge the conflicts with the development branch? I need to make a better PR guide.

@bmeutzner
Copy link

Is this going to be merged into main?

@ConnorChristie
Copy link
Author

@swar Fixed merge conflicts and added back the previous _analyze_log_end_date() method for use in the standard view.

@xludodx
Copy link

xludodx commented May 25, 2021

Hello,
This option would be really useful.
I tried to use your code but I can't have the history working :(
File "C:\Users\ldl\Downloads\Swar-Chia-Plot-Manager-main\plotmanager\library\utilities\commands.py", line 191, in view_history
chia_location, log_directory, config_jobs, manager_check_interval, max_concurrent, progress_settings,
ValueError: too many values to unpack (expected 9)

And if I correct this error, I get an error about "date".

Could you help ?
Many thanks

@ConnorChristie
Copy link
Author

Hello,
This option would be really useful.
I tried to use your code but I can't have the history working :(
File "C:\Users\ldl\Downloads\Swar-Chia-Plot-Manager-main\plotmanager\library\utilities\commands.py", line 191, in view_history
chia_location, log_directory, config_jobs, manager_check_interval, max_concurrent, progress_settings,
ValueError: too many values to unpack (expected 9)

And if I correct this error, I get an error about "date".

Could you help ?
Many thanks

Please try again after my latest commit. A few things changed from the last time I tested but it should work now.

@xludodx
Copy link

xludodx commented May 26, 2021

Hello,
This option would be really useful.
I tried to use your code but I can't have the history working :(
File "C:\Users\ldl\Downloads\Swar-Chia-Plot-Manager-main\plotmanager\library\utilities\commands.py", line 191, in view_history
chia_location, log_directory, config_jobs, manager_check_interval, max_concurrent, progress_settings,
ValueError: too many values to unpack (expected 9)
And if I correct this error, I get an error about "date".
Could you help ?
Many thanks

Please try again after my latest commit. A few things changed from the last time I tested but it should work now.

Thanks !! Perfectly working :)

@ConnorChristie
Copy link
Author

@swar Do you think this well be able to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants