Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/ast): Use smallvec and reduce size if possible #10026

Closed
wants to merge 183 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Feb 12, 2025

@kdy1 kdy1 added this to the Planned milestone Feb 12, 2025
@kdy1 kdy1 self-assigned this Feb 12, 2025
Copy link

changeset-bot bot commented Feb 12, 2025

⚠️ No Changeset found

Latest commit: df55680

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1
Copy link
Member Author

kdy1 commented Feb 17, 2025

Numbers for RSS of the SWC minifier as standalone:

main:

   process: user: 5.075 s, system: 1.249 s, faults: 2, rss: 277.2 MiB, commit: 1.9 GiB

With small vector optimization:

   process: user: 4.944 s, system: 1.193 s, faults: 0, rss: 267.2 MiB, commit: 2.0 GiB

The gain is only 10MB, so I think this optimization does not worth the effort

@kdy1 kdy1 closed this Feb 17, 2025
@kdy1 kdy1 deleted the ast-perf branch February 17, 2025 04:37
@kdy1 kdy1 modified the milestones: Planned, v1.10.17 Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

es/ast: ExprOrSpead#spread can be Option<BytePos> es/ast: Box<Expr> can use SmallVec for free
1 participant