-
-
Notifications
You must be signed in to change notification settings - Fork 781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use spoiler divs for expandable launch instructions #1064
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-inflammation/compare/md-outputs..md-outputs-PR-1064 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2023-09-06 19:07:37 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🚀 Thanks for the reference to carpentries/sandpaper#502 (comment) in description @tobyhodges!
Auto-generated via {sandpaper} Source : 4c3fc9c Branch : main Author : Indraneel Chakraborty <[email protected]> Time : 2023-09-06 19:27:13 +0000 Message : Merge pull request #1064 from tobyhodges/use-spoiler-divs use spoiler divs for expandable launch instructions
Auto-generated via {sandpaper} Source : 8db5ae8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-06 19:28:44 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4c3fc9c Branch : main Author : Indraneel Chakraborty <[email protected]> Time : 2023-09-06 19:27:13 +0000 Message : Merge pull request #1064 from tobyhodges/use-spoiler-divs use spoiler divs for expandable launch instructions
Auto-generated via {sandpaper} Source : 8db5ae8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-06 19:28:44 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4c3fc9c Branch : main Author : Indraneel Chakraborty <[email protected]> Time : 2023-09-06 19:27:13 +0000 Message : Merge pull request #1064 from tobyhodges/use-spoiler-divs use spoiler divs for expandable launch instructions
Auto-generated via {sandpaper} Source : 8db5ae8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-06 19:28:44 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4c3fc9c Branch : main Author : Indraneel Chakraborty <[email protected]> Time : 2023-09-06 19:27:13 +0000 Message : Merge pull request #1064 from tobyhodges/use-spoiler-divs use spoiler divs for expandable launch instructions
Auto-generated via {sandpaper} Source : 8db5ae8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-06 19:28:44 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4c3fc9c Branch : main Author : Indraneel Chakraborty <[email protected]> Time : 2023-09-06 19:27:13 +0000 Message : Merge pull request #1064 from tobyhodges/use-spoiler-divs use spoiler divs for expandable launch instructions
Auto-generated via {sandpaper} Source : 8db5ae8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-06 19:28:44 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4c3fc9c Branch : main Author : Indraneel Chakraborty <[email protected]> Time : 2023-09-06 19:27:13 +0000 Message : Merge pull request #1064 from tobyhodges/use-spoiler-divs use spoiler divs for expandable launch instructions
Auto-generated via {sandpaper} Source : 8db5ae8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-06 19:28:44 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4c3fc9c Branch : main Author : Indraneel Chakraborty <[email protected]> Time : 2023-09-06 19:27:13 +0000 Message : Merge pull request #1064 from tobyhodges/use-spoiler-divs use spoiler divs for expandable launch instructions
Auto-generated via {sandpaper} Source : 8db5ae8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-06 19:28:44 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4c3fc9c Branch : main Author : Indraneel Chakraborty <[email protected]> Time : 2023-09-06 19:27:13 +0000 Message : Merge pull request #1064 from tobyhodges/use-spoiler-divs use spoiler divs for expandable launch instructions
Auto-generated via {sandpaper} Source : 8db5ae8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-06 19:28:44 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4c3fc9c Branch : main Author : Indraneel Chakraborty <[email protected]> Time : 2023-09-06 19:27:13 +0000 Message : Merge pull request swcarpentry#1064 from tobyhodges/use-spoiler-divs use spoiler divs for expandable launch instructions
Auto-generated via {sandpaper} Source : 8db5ae8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-06 19:28:44 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4c3fc9c Branch : main Author : Indraneel Chakraborty <[email protected]> Time : 2023-09-06 19:27:13 +0000 Message : Merge pull request #1064 from tobyhodges/use-spoiler-divs use spoiler divs for expandable launch instructions
Auto-generated via {sandpaper} Source : 8db5ae8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-06 19:28:44 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4c3fc9c Branch : main Author : Indraneel Chakraborty <[email protected]> Time : 2023-09-06 19:27:13 +0000 Message : Merge pull request #1064 from tobyhodges/use-spoiler-divs use spoiler divs for expandable launch instructions
Auto-generated via {sandpaper} Source : 8db5ae8 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-09-06 19:28:44 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 4c3fc9c Branch : main Author : Indraneel Chakraborty <[email protected]> Time : 2023-09-06 19:27:13 +0000 Message : Merge pull request #1064 from tobyhodges/use-spoiler-divs use spoiler divs for expandable launch instructions
If this pull request addresses an open issue on the repository, please add 'Closes #NN' below, where NN is the issue number.
Please briefly summarise the changes made in the pull request, and the reason(s) for making these changes.
This switches floating solution divs in the setup instructions for the
spoiler
class introduced in the recent release of the lesson infrastructureIf any relevant discussions have taken place elsewhere, please provide links to these.
See carpentries/sandpaper#502 (comment) for an example of a spoiler class div in action.