Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clips Path should preserve transforms #61

Merged
merged 3 commits into from
Feb 2, 2025
Merged

Clips Path should preserve transforms #61

merged 3 commits into from
Feb 2, 2025

Conversation

swhitty
Copy link
Owner

@swhitty swhitty commented Feb 2, 2025

Fixes an issue where clips paths were ignoring any attached transform attributes.

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.02%. Comparing base (7429012) to head (7376d39).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
SwiftDraw/LayerTree.CommandGenerator.swift 75.00% 2 Missing ⚠️
SwiftDraw/LayerTree.Builder.swift 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   85.03%   85.02%   -0.02%     
==========================================
  Files          78       78              
  Lines        7176     7191      +15     
==========================================
+ Hits         6102     6114      +12     
- Misses       1074     1077       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swhitty swhitty linked an issue Feb 2, 2025 that may be closed by this pull request
@swhitty swhitty merged commit 8abb043 into main Feb 2, 2025
19 checks passed
@swhitty swhitty deleted the clips-path branch February 2, 2025 02:53
@swhitty swhitty restored the clips-path branch February 11, 2025 09:29
@swhitty swhitty deleted the clips-path branch February 11, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon bottom is clipped
1 participant