Add a Bundle.testTarget property.
#848
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds an experimental class property to `Bundle` in the Foundation cross-import overlay. The property's value represents the bundle containing the test target. On Apple platforms, this is an XCTest bundle. Elsewhere, it's just the main bundle. This is an experimental interface only.
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci test |
|
@swift-ci test |
|
@swift-ci test Windows |
parkera
reviewed
Dec 11, 2024
| /// | ||
| /// - Note: This property accesses the file system the first time it is used. | ||
| @_spi(Experimental) | ||
| public static var testTarget: Bundle { |
There was a problem hiding this comment.
I do not think we should extend Foundation this way from Testing. The correct way would be implementation in Foundation itself, following the process there.
There was a problem hiding this comment.
This is a prototype only. 🙂 We can certainly follow the Foundation review process for this feature (in whatever form it takes) although due to layering it may need to live here in the overlay.
I have no plans to merge this without your team's signoff!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an experimental class property to
Bundlein the Foundation cross-import overlay. The property's value represents the bundle containing the test target. On Apple platforms, this is an XCTest bundle. Elsewhere, it's just the main bundle.This is an experimental interface only.
Checklist: