added commented out test for Including parent items in arrays wankdan…

…ker#50
switzer · Oct 11, 2019 · d57b328 · d57b328
1 parent 7d8252d
commit d57b328
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 2 deletions.
diff --git a/src/object-mapper.js b/src/object-mapper.js
@@ -251,12 +251,13 @@ function update_arr(dest, key, data, keys, context)
   if (key.add) {
     if (data !== null && typeof data !== 'undefined') {
       dest = dest || []
-      dest.push(data)
+      //dest.push(data)
+      dest = dest.concat(data)
     }
     return dest
   }
 
-  // Make sure that there is an array item for each item in the data array
+  // If the data is in an array format then make sure that there is a dest index for each data index
   if (Array.isArray(data)) {
     dest = dest || []
     // Loop through each index in the data array and update the destination object with the data

diff --git a/test/test.js b/test/test.js
@@ -2202,3 +2202,35 @@ test('2 array mapping wraps destination in an unwanted array #49', function (t)
   t.end();
 });
 
+// test('Including parent items in arrays #50', function (t) {
+//   const src = {
+//     "a": "AA",
+//     "b": "BB",
+//     "array": [
+//         { "x": "one" },
+//         { "x": "two" }
+//     ]
+// };
+//   const map = {
+//     "array[].x": "results[].ex",
+//     "a": "results[].aye",
+//     "b": "results[].bee"
+// }
+//   var expect = {
+//     "results": [
+//         {
+//             "aye": "AA",
+//             "bee": "BB",
+//             "ex": "one"
+//         },
+//         {
+//             "aye": "AA",
+//             "bee": "BB",
+//             "ex": "two"
+//         }
+//     ]
+// };
+//   var result = om(src, map);
+//   t.deepEqual(result, expect);
+//   t.end();
+// });