Check SpEC version when importing #6467
Open
+48
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Check the SpEC version when import Python modules to make sure it's compatible (of course the real solution is to port SpEC modules into SpECTRE when we need them or factor the code into a separate repository, but that requires some work and comes with a maintenance burden keeping the two codes in sync).
Upgrade instructions
To use eccentricity control, make sure you're pointing to a recent enough SpEC version (Aug 2024) and update your Python environment with
pip install -r Support/Python/requirements.txt
to pick up the newgit
dependency (if running on CaltechHPC you don't have to do anything).Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments