Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check SpEC version when importing #6467

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Feb 1, 2025

Proposed changes

Check the SpEC version when import Python modules to make sure it's compatible (of course the real solution is to port SpEC modules into SpECTRE when we need them or factor the code into a separate repository, but that requires some work and comes with a maintenance burden keeping the two codes in sync).

Upgrade instructions

To use eccentricity control, make sure you're pointing to a recent enough SpEC version (Aug 2024) and update your Python environment with pip install -r Support/Python/requirements.txt to pick up the new git dependency (if running on CaltechHPC you don't have to do anything).

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested a review from nilsdeppe February 1, 2025 07:04
@knelli2
Copy link
Contributor

knelli2 commented Feb 7, 2025

Will this be superceded by #6471? @nilsvu @nilsdeppe

@nilsvu nilsvu force-pushed the check_spec_import branch from 8049ede to 20b7068 Compare February 7, 2025 01:54
@nilsvu
Copy link
Member Author

nilsvu commented Feb 7, 2025

no I don't think so. rebased.

Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI very unhappy

@nilsvu nilsvu force-pushed the check_spec_import branch from 20b7068 to dd2e8f3 Compare February 7, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants