-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BBH pipeline: write eccentricity params to file, add CLI to compute params & plot #6468
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a review, just small question/idea :)
# Stop eccentricity control if eccentricity is below threshold | ||
if eccentricity < 0.001: | ||
if ecc_params["Eccentricity"] < 0.001: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a quick glance because I'll adapt a lot of this to BNS at some point. Should the threshold be specifiable somewhere? In SpEC we've had a harder time getting lower eccs for high q & chi runs. So much so that sometimes in BFI we just override the BFI-based target ecc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes definitely, we can just make it a parameter, that's very easy to do
bb55757
to
8e884fc
Compare
@nilsvu I'll review after conflicts are fixed |
rebased |
Proposed changes
Creates plots of the path through orbital parameter space like this:
![ecc](https://private-user-images.githubusercontent.com/746230/410725154-7432fd7d-ad7f-4c60-86ae-263ff5ac31af.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1MTczMDIsIm5iZiI6MTczOTUxNzAwMiwicGF0aCI6Ii83NDYyMzAvNDEwNzI1MTU0LTc0MzJmZDdkLWFkN2YtNGM2MC04NmFlLTI2M2ZmNWFjMzFhZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQwNzEwMDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02MzBkYWY4MzM0MzQ5ZDRkNDYyZGYwMWEyMzE2ZjJiMGExNjk5MDU3N2NmMWZlMjRkZmQ3ZTNhMTg5Yjg4YzE4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.vCyyIVS0761C0wmYZveKq770ySdtzuSQONme07szFBc)
Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments