Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBH pipeline: write eccentricity params to file, add CLI to compute params & plot #6468

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Feb 3, 2025

Proposed changes

Creates plots of the path through orbital parameter space like this:
ecc

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested a review from knelli2 February 3, 2025 20:15
@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label Feb 3, 2025
@nilsvu nilsvu changed the title BBH pipeline: write eccentricity params to file, add CLI to compute params BBH pipeline: write eccentricity params to file, add CLI to compute params & plot Feb 3, 2025
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a review, just small question/idea :)

# Stop eccentricity control if eccentricity is below threshold
if eccentricity < 0.001:
if ecc_params["Eccentricity"] < 0.001:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a quick glance because I'll adapt a lot of this to BNS at some point. Should the threshold be specifiable somewhere? In SpEC we've had a harder time getting lower eccs for high q & chi runs. So much so that sometimes in BFI we just override the BFI-based target ecc.

Copy link
Member Author

@nilsvu nilsvu Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes definitely, we can just make it a parameter, that's very easy to do

@nilsvu nilsvu force-pushed the ecc_cli branch 2 times, most recently from bb55757 to 8e884fc Compare February 4, 2025 09:01
@knelli2
Copy link
Contributor

knelli2 commented Feb 7, 2025

@nilsvu I'll review after conflicts are fixed

@nilsvu
Copy link
Member Author

nilsvu commented Feb 7, 2025

rebased

knelli2
knelli2 previously approved these changes Feb 7, 2025
@knelli2 knelli2 merged commit 099b9c8 into sxs-collaboration:develop Feb 11, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants