-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boolean function trait for TruthTable #24
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
==========================================
+ Coverage 81.45% 83.07% +1.62%
==========================================
Files 49 65 +16
Lines 895 1034 +139
==========================================
+ Hits 729 859 +130
- Misses 166 175 +9 ☔ View full report in Codecov by Sentry. |
Only the methods in that impl block require it.
Precursor to their reuse for tables. Includes renaming from ExpressionXIterator to just XIterator, a new constructor method and 'static trait bound.
AurumTheEnd
force-pushed
the
feat/boolean-function-trait-tables
branch
from
May 2, 2024 14:06
2114acc
to
bf1baa6
Compare
AurumTheEnd
force-pushed
the
feat/boolean-function-trait-tables
branch
from
May 2, 2024 14:11
bf1baa6
to
0461bba
Compare
To be able to use it without an underlying structure.
AurumTheEnd
force-pushed
the
feat/boolean-function-trait-tables
branch
from
May 8, 2024 12:50
fb6b358
to
2f15b20
Compare
daemontus
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AurumTheEnd
force-pushed
the
feat/boolean-function-trait-tables
branch
from
May 9, 2024 13:25
7a7e704
to
1977edc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #21 from commit 94925d3, meaning that that PR should be merged first before this one.