Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean function trait for TruthTable #24

Merged
merged 18 commits into from
May 9, 2024

Conversation

AurumTheEnd
Copy link
Contributor

@AurumTheEnd AurumTheEnd commented May 2, 2024

Builds on #21 from commit 94925d3, meaning that that PR should be merged first before this one.

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 93.40659% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 83.07%. Comparing base (dd44a31) to head (1977edc).

Files Patch % Lines
src/table/traits/boolean_function.rs 93.67% 5 Missing ⚠️
src/table/iterators/domain.rs 0.00% 2 Missing ⚠️
src/table/iterators/mod.rs 0.00% 2 Missing ⚠️
src/table/traits/bit/mod.rs 88.88% 2 Missing ⚠️
src/iterators/support.rs 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
+ Coverage   81.45%   83.07%   +1.62%     
==========================================
  Files          49       65      +16     
  Lines         895     1034     +139     
==========================================
+ Hits          729      859     +130     
- Misses        166      175       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurumTheEnd AurumTheEnd force-pushed the feat/boolean-function-trait-tables branch from 2114acc to bf1baa6 Compare May 2, 2024 14:06
@AurumTheEnd AurumTheEnd force-pushed the feat/boolean-function-trait-tables branch from bf1baa6 to 0461bba Compare May 2, 2024 14:11
@AurumTheEnd AurumTheEnd force-pushed the feat/boolean-function-trait-tables branch from fb6b358 to 2f15b20 Compare May 8, 2024 12:50
@AurumTheEnd AurumTheEnd marked this pull request as ready for review May 8, 2024 12:56
@AurumTheEnd AurumTheEnd requested a review from daemontus May 8, 2024 12:57
Copy link
Member

@daemontus daemontus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AurumTheEnd AurumTheEnd force-pushed the feat/boolean-function-trait-tables branch from 7a7e704 to 1977edc Compare May 9, 2024 13:25
@daemontus daemontus merged commit 381c69e into main May 9, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants