Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmarks #28

Merged
merged 8 commits into from
May 22, 2024
Merged

Benchmarks #28

merged 8 commits into from
May 22, 2024

Conversation

daemontus
Copy link
Member

@daemontus daemontus commented May 20, 2024

Proposes several benchmark problems which we can use to compare with PyEDA.

Also adds some minimum viable bindings for Bdd to implement these benchmarks.

(the history is a bit messed up because it initially branched off feat/bdd, but the actually relevant things should be contained in the benchmarks folder)

@daemontus daemontus requested a review from AurumTheEnd May 20, 2024 14:22
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 17.33333% with 62 lines in your changes are missing coverage. Please review.

Project coverage is 81.81%. Comparing base (a3f9b1e) to head (e82fcbf).

Current head e82fcbf differs from pull request most recent head 1f3a54e

Please upload reports for the commit 1f3a54e to get more accurate results.

Files Patch % Lines
src/bindings/bdd.rs 0.00% 27 Missing ⚠️
src/bdd/mod.rs 0.00% 12 Missing ⚠️
src/bindings/table.rs 0.00% 11 Missing ⚠️
src/bdd/traits/bit/not.rs 0.00% 4 Missing ⚠️
src/bdd/traits/bit/and.rs 50.00% 2 Missing ⚠️
src/bdd/traits/bit/or.rs 50.00% 2 Missing ⚠️
src/bdd/traits/bit/xor.rs 50.00% 2 Missing ⚠️
src/bindings/expression.rs 0.00% 1 Missing ⚠️
src/bindings/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
- Coverage   86.34%   81.81%   -4.54%     
==========================================
  Files          83       85       +2     
  Lines        1282     1353      +71     
==========================================
  Hits         1107     1107              
- Misses        175      246      +71     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurumTheEnd
Copy link
Contributor

AurumTheEnd commented May 22, 2024

@daemontus I further resolved the conflicting two commits (feat(tests): bdd.domain and Fix failed rebase) by squashing them, effectively canceling their code changes.

Will merge this after the pipeline.

@AurumTheEnd AurumTheEnd merged commit 7f9d435 into main May 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants