Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactor of expressions #5

Merged
merged 3 commits into from
Nov 3, 2023
Merged

Minor refactor of expressions #5

merged 3 commits into from
Nov 3, 2023

Conversation

AurumTheEnd
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ea60f4f) 75.63% compared to head (16d30c8) 77.27%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   75.63%   77.27%   +1.64%     
==========================================
  Files           5        5              
  Lines         119      110       -9     
==========================================
- Hits           90       85       -5     
+ Misses         29       25       -4     
Files Coverage Δ
src/expressions/mod.rs 69.23% <90.90%> (+1.66%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AurumTheEnd AurumTheEnd changed the title Minor changes to expressions Minor refactor of expressions Nov 3, 2023
@AurumTheEnd
Copy link
Contributor Author

Notes:

  • inspire with parser from https://github.com/sybila/biodivine-lib-bdd/blob/master/src/boolean_expression/_impl_parser.rs
    • vylepšit chování not operátoru při nalezení terminal
    • tzv. "recursive descent parser", do budoucna: efektivnější by byl state-machine parser
  • by default povolit alphanumerické znaky + -_, ale mít syntax pro backtick {VAR;&&-fas} backtick
  • maybe v budoucnu povolit další znaky v názvu variable, které nebudou kolidovat s ničím jiným
  • priority and > xor > or > impl > ekv
  • parsing binárních operátorů: rozseknu podle &&, podívám se, jestli alespoň jeden z výsledků je také &&
    • nebo možná najít všechny výskyty && a hned rozbít
  • asociativita operátorů: right-asoc dělá find-first, left-asoc by dělal find_last

@AurumTheEnd AurumTheEnd merged commit c2d0e54 into main Nov 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant