Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of
lib-param-bn
andlib-bdd
support a generalized sanitization process at the level of individualBdd
andBddVariableSet
objects (it also supports a wider range of use cases, although it still won't reorder variables). Hence we no longer need the sanitization code directly in the model checker.The process is tested in the original libraries, but I haven't added specific tests here, I just rely on the existing tests. If some extra testing should be added to verify everything is working as intended, please let me know.
Also, we don't necessarily need to merge this anytime soon, but it's nice to remove the duplicate functionality.