-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for variable domains #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and tests still in making.
… Needs testing though.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 89.39% 87.18% -2.22%
==========================================
Files 24 26 +2
Lines 792 944 +152
==========================================
+ Hits 708 823 +115
- Misses 84 121 +37 ☔ View full report in Codecov by Sentry. |
This was referenced Jan 31, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, we add support for directly restricting quantified variables' domains in HCTL formulae. These variable domains behave the same way as wild-card propositions introduced in #9, and they are evaluated to an arbitrary (coloured) set given by the user. The syntax is following:
!{x} in %domain%:
, and the same goes for other quantifiers. This way, the user can directly restrict the domain of every{x}
encountered during bottom-up computation (makes the formula more readable and speeds up the computation).The following equivalences hold:
!{x} in %A%: phi
=!{x}: %A% & phi
3{x} in %A%: @{x}: phi
=3{x}: @{x}: %A% & phi
V{x} in %A%: @{x}: phi
=V{x}: @{x}: %A% => phi
These changes are now also available as part of the tool itself, not just the library. The model checker can now load an archive with BDDs to be substituted for the wild-card properties and variable domains. It can also generate an archive with resulting BDDs.
Furthermore, this PR includes some refactoring, mainly related to syntax trees and the test suite.