-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for namespaces #4
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4 +/- ##
==========================================
- Coverage 44.94% 44.83% -0.11%
==========================================
Files 12 12
Lines 485 562 +77
==========================================
+ Hits 218 252 +34
- Misses 267 310 +43
☔ View full report in Codecov by Sentry. |
PR is mostly ready for review. What changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All clear.
This PR adds support for namespaces in
XmlChild
using newly added methods inxml-doc
.Every
XmlChild
now has a namespace URL, such that the retrieved elements must match both name (as before) and the namespace URL (the URL is resolved through standard XML prefixes). When updating or creating a newXmlChild
, the namespace is automatically set using the "closest" prefix that references the required namespace.TODO: A similar mechanism still needs to be added to attributes. However, attributes follow slightly different resolution rules.