Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary of admissible update functions #56

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Summary of admissible update functions #56

merged 5 commits into from
Nov 5, 2024

Conversation

ondrej33
Copy link
Member

@ondrej33 ondrej33 commented Nov 5, 2024

This PR is mainly about adding a summary of admissible update functions throughout the set of candidate networks.
Now, as part of the results report, we show how many variants of each update function are admissible within the candidate ensemble. Furthermore, as part of the exported results archive, we list the admissible variants of each update function.
The changes to the code are the following:

  • The new Rust module analysis/update_fn_details implements the functionality through wrappers for relevant parts of lib-param-bn. Everything is done via symbolic projections, so it should be scalable and efficient.
  • InferenceResults contains a new field that maps variables to the number of their candidate update functions
    • This is automatically computed at the end of the inference solver's computation.
    • This is used within results exporting on the backend and results displaying on the frontend.
  • During the results export, all update function variants are instantiated. A new folder is added to the results zip, with a file for each variable where all variants are listed (line-by-line).

Apart from the main feature above, we also touched upon the following:

  • fixing issues with automatically generated documentation
  • updating colour scheme for quick-help message blocks, and some other details
  • fixing a few little UI bugs (some of them introduced in the previous PR)
  • redundant serde implementation for Layout was removed, and the whole module was restructured and simlified

@ondrej33 ondrej33 merged commit 8192d4f into main Nov 5, 2024
6 checks passed
@ondrej33 ondrej33 deleted the detailed-results branch November 5, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant