Summary of admissible update functions #56
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mainly about adding a summary of admissible update functions throughout the set of candidate networks.
Now, as part of the results report, we show how many variants of each update function are admissible within the candidate ensemble. Furthermore, as part of the exported results archive, we list the admissible variants of each update function.
The changes to the code are the following:
analysis/update_fn_details
implements the functionality through wrappers for relevant parts oflib-param-bn
. Everything is done via symbolic projections, so it should be scalable and efficient.InferenceResults
contains a new field that maps variables to the number of their candidate update functionsApart from the main feature above, we also touched upon the following:
serde
implementation forLayout
was removed, and the whole module was restructured and simlified