-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parsing improvements - merge improve-parsing
into master
#114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created requirements.txt file
Added tests for replacing abstract syntax
Extracting parsing tests
79 core tests
Rule labels in regulations and regular regulations
error raised when alias in rule is not defined
unique atomic agents
replication rules
Fix tests
xtrojak
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #70 and represents an overhaul of the parsing module for eBCSgen. It integrates multiple smaller pull requests developed over an extended period, each addressing specific issues and introducing enhancements to ensure robust, flexible, and more efficient parsing capabilities.
Parsing corrections and features
insert_atomic_to_complex
,insert_struct_to_complex
,insert_atomic_to_struct
) to enhance insertion validity and data integrityinsert_atomic_to_complex
andinsert_struct_to_complex
do not check if the replaced agent is unspecified (i.e. atomic has'_'
feature and structure has no atomics specified) #72complex
es inabstract_sequence
by modifying the grammar to support complex names as valuesabstract_sequence
#89;
to better check for existing labels::
, same as compartment specification, instead of:
ComplexParsingError
when mismatches are detectedTesting
objects_testing.py
to eliminate redundancy and text models shifted to.txt
files::
, etcAll tests are passing, indicating that the updates are stable and maintain the integrity.