Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump packages #236

Merged
merged 4 commits into from
Dec 8, 2023
Merged

Conversation

mj52951
Copy link
Collaborator

@mj52951 mj52951 commented Oct 31, 2023

Bumping packages so that code can be refactored to use sygma-core

Copy link
Collaborator

@mpetrun5 mpetrun5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests and then we'll merge this first and then we can go into event handlers

go.mod Outdated Show resolved Hide resolved
@mpetrun5 mpetrun5 changed the title fix: Refactoring event handlers chore: bump packages Nov 2, 2023
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Go Test coverage is 64.5 %\ ✨ ✨ ✨

Copy link
Contributor

Go Test coverage is 64.5 %\ ✨ ✨ ✨

@mj52951 mj52951 force-pushed the mj52951/refactor-event-handlers branch from 1bb51b8 to 0b11d6c Compare November 13, 2023 10:08
Copy link
Contributor

Go Test coverage is 64.5 %\ ✨ ✨ ✨

Copy link
Contributor

Go Test coverage is 64.5 %\ ✨ ✨ ✨

@mj52951 mj52951 marked this pull request as ready for review November 13, 2023 11:32
@mj52951 mj52951 requested review from mpetrun5 and MakMuftic and removed request for MakMuftic and P1sar November 13, 2023 11:32
@mj52951
Copy link
Collaborator Author

mj52951 commented Dec 6, 2023

Checks are not passing because dependency review detected a vulnerable package. References and more info about it could be found here: GHSA-v9jh-j8px-98vq

Geth team response is that because the GraphQL feature is an option, it is out of scope of the Ethereum Bug Bounty program. Also, the team has no intention of fixing this issue. (https://blog.mevsec.com/posts/geth-dos-with-graphql/#5-ethereum-response)

@mpetrun5 mpetrun5 merged commit 982130e into sygma-core-refactor Dec 8, 2023
5 of 6 checks passed
@mpetrun5 mpetrun5 deleted the mj52951/refactor-event-handlers branch December 8, 2023 11:55
@mpetrun5 mpetrun5 restored the mj52951/refactor-event-handlers branch December 8, 2023 11:55
@mpetrun5 mpetrun5 deleted the mj52951/refactor-event-handlers branch December 8, 2023 11:55
mj52951 added a commit that referenced this pull request Jan 4, 2024
@mj52951 mj52951 mentioned this pull request Mar 28, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants